-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render a document detailed view with document even if there's a library without pickup location in the organisation #598
Labels
bug (critical)
Blocking issue, should be fixed ASAP
Comments
jma
added a commit
to jma/rero-ils
that referenced
this issue
Nov 7, 2019
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: rero#598. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
added a commit
to jma/rero-ils
that referenced
this issue
Nov 8, 2019
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: rero#598. * Fixes import document using EAN from the BNF server. Closes: rero#607. * Improves logs to BNF document importation. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
added a commit
to jma/rero-ils
that referenced
this issue
Nov 8, 2019
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: rero#598. * Fixes import document using EAN from the BNF server. Closes: rero#607. * Improves logs to BNF document importation. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
added a commit
to jma/rero-ils
that referenced
this issue
Nov 8, 2019
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: rero#598. * Fixes import document using EAN from the BNF server. Closes: rero#607. * Improves logs to BNF document importation. * Fixes logged user initial user menu. * Fixes reset password links in the user email when a librarian create a patron. * Forces instance jinja templates to be loaded before all other templates. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
added a commit
to jma/rero-ils
that referenced
this issue
Nov 8, 2019
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: rero#598. * Fixes import document using EAN from the BNF server. Closes: rero#607. * Improves logs to BNF document importation. * Fixes logged user initial user menu. * Fixes reset password links in the user email when a librarian create a patron. Closes: rero#608. * Forces instance jinja templates to be loaded before all other templates. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
added a commit
to jma/rero-ils
that referenced
this issue
Nov 8, 2019
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: rero#598. * Fixes import document using EAN from the BNF server. Closes: rero#607. * Improves logs to BNF document importation. * Fixes logged user initial user menu. * Fixes reset password links in the user email when a librarian create a patron. Closes: rero#608. * Forces instance jinja templates to be loaded before all other templates. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
added a commit
to jma/rero-ils
that referenced
this issue
Nov 11, 2019
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: rero#598. * Fixes import document using EAN from the BNF server. Closes: rero#607. * Improves logs to BNF document importation. * Fixes logged user initial user menu. * Fixes reset password links in the user email when a librarian create a patron. Closes: rero#608. * Forces instance jinja templates to be loaded before all other templates. * Makes exception variable more explicit e -> error. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
iGormilhit
pushed a commit
that referenced
this issue
Nov 11, 2019
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: #598. * Fixes import document using EAN from the BNF server. Closes: #607. * Improves logs to BNF document importation. * Fixes logged user initial user menu. * Fixes reset password links in the user email when a librarian create a patron. Closes: #608. * Forces instance jinja templates to be loaded before all other templates. * Makes exception variable more explicit e -> error. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
If, inside a given organisation, there's a library with locations, but none being a pickup location, then a reader cannot load any document detailed view with item of this organisation, because the system fails to populate the request button dropdown menu.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The document detailed view rendering should succeed, but without pickup location for a give library in the request button dropdown menu.
Software version
ils.test.rero.ch, v0.5.1
ilsdev.test.rero.ch, 9aa529c
Additional information
When creating the first location of a library, the
pickup location
check box should be activated, without the possibility of deactivating it, until there's another pickup location for this library.The text was updated successfully, but these errors were encountered: