instance: fix several bugs #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
maj-workshop-fixes
branch
6 times, most recently
from
f0413a3 to
fd8d498
Compare
jma
force-pushed
the
maj-workshop-fixes
branch
from
fd8d498 to
60f348a
Compare
rerowep
approved these changes
Nov 9, 2019
rero_ils/modules/documents/views.py
Outdated
| # other errors | ||
| except Exception: | ||
| sys.stdout.flush() | ||
| except Exception as e: |
There was a problem hiding this comment.
Recommendation from python: Use more verbose names for your variables for clarity. e--> err ?
rero_ils/modules/documents/views.py
Outdated
| 'errors': { | ||
| 'code': status_code, | ||
| 'title': 'An unexpected error has been raise.', | ||
| 'detail': 'Error: {}'.format(e) |
There was a problem hiding this comment.
I prefer to use named format parameters:
'Error: {err}'.format(err=err)
rero_ils/modules/documents/views.py
Outdated
| } | ||
| return jsonify(response), 500 | ||
| current_app.logger.error( | ||
| '{}: {}'.format( |
rerowep
reviewed
Nov 9, 2019
| @@ -562,7 +562,7 @@ | |||
| "title": "Authors", | |||
| "description": "Author(s) of the resource. Can be either persons or organisations.", | |||
| "type": "array", | |||
| "minItems": 0, | |||
| "minItems": 1, | |||
There was a problem hiding this comment.
See: #611
Your changes will be erased by a bootstrap!
There was a problem hiding this comment.
This should not be addressed by this PR. It has been commited buy error.
iGormilhit
approved these changes
Nov 11, 2019
* Fixes item types type validation. * Fixes validation message for patron phone number. * Adds opening hours to the library of the 3th organisation. * Fixes document detailed view for patrons with organisation without pickup locations. Closes: rero#598. * Fixes import document using EAN from the BNF server. Closes: rero#607. * Improves logs to BNF document importation. * Fixes logged user initial user menu. * Fixes reset password links in the user email when a librarian create a patron. Closes: rero#608. * Forces instance jinja templates to be loaded before all other templates. * Makes exception variable more explicit e -> error. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
maj-workshop-fixes
branch
from
60f348a to
33ab836
Compare
jma
requested review from
AoNoOokami,
benerken,
blankoworld,
iGormilhit and
lauren-d
lauren-d
approved these changes
Nov 11, 2019
iGormilhit
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pickup locations. Closes: Render a document detailed view with document even if there's a library without pickup location in the organisation #598.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
Code review check list