Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import document from BnF not working #607

Closed
pronguen opened this issue Nov 7, 2019 · 0 comments
Closed

Import document from BnF not working #607

pronguen opened this issue Nov 7, 2019 · 0 comments
Assignees
@jma
Labels
bug (critical) Blocking issue, should be fixed ASAP f: editor Concerns editor based on JSON schema AND custom editor

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 7, 2019

Describe the issue
The import function when creating a new document doesn't work. After having entered a EAN (that exists at BnF!) and having clicked on "submit", no response is given. The import is not realised.

To Reproduce

  1. Click on "Create a new document"
  2. Enter a EAN (ex: 9783257300215, 9782298060843, 9782081233010)
  3. Click on "submit"

Expected behavior

  • if the import is realised, display green toast message: "Import sucessuful"
  • if the import didn't work because EAN was not found, display red/orange toast message: "The import failed: EAN was not found"
  • if the import didn't work because of BnF server timeout or inaccessible, display red/orange toast message: "The import failed: BnF server doesn't respond"

Software version
https://ils.test.rero.ch/
v0.5.1
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor import records bug (critical) Blocking issue, should be fixed ASAP labels Nov 7, 2019
@jma jma self-assigned this Nov 8, 2019
jma added a commit to jma/rero-ils that referenced this issue Nov 8, 2019
@jma
instance: fix several bugs
62fa48a 
* Fixes item types type validation.
* Fixes validation message for patron phone number.
* Adds opening hours to the library of the 3th organisation.
* Fixes document detailed view for patrons with organisation without
pickup locations. Closes: rero#598.
* Fixes import document using EAN from the BNF server. Closes: rero#607.
* Improves logs to BNF document importation.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Nov 8, 2019
@jma
instance: fix several bugs
f8f5de0 
* Fixes item types type validation.
* Fixes validation message for patron phone number.
* Adds opening hours to the library of the 3th organisation.
* Fixes document detailed view for patrons with organisation without
pickup locations. Closes: rero#598.
* Fixes import document using EAN from the BNF server. Closes: rero#607.
* Improves logs to BNF document importation.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Nov 8, 2019
Merged
6 tasks
jma added a commit to jma/rero-ils that referenced this issue Nov 8, 2019
@jma
instance: fix several bugs
f0413a3 
* Fixes item types type validation.
* Fixes validation message for patron phone number.
* Adds opening hours to the library of the 3th organisation.
* Fixes document detailed view for patrons with organisation without
pickup locations. Closes: rero#598.
* Fixes import document using EAN from the BNF server. Closes: rero#607.
* Improves logs to BNF document importation.
* Fixes logged user initial user menu.
* Fixes reset password links in the user email when a librarian create a
patron.
* Forces instance jinja templates to be loaded before all other
templates.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Nov 8, 2019
@jma
instance: fix several bugs
fd8d498 
* Fixes item types type validation.
* Fixes validation message for patron phone number.
* Adds opening hours to the library of the 3th organisation.
* Fixes document detailed view for patrons with organisation without
pickup locations. Closes: rero#598.
* Fixes import document using EAN from the BNF server. Closes: rero#607.
* Improves logs to BNF document importation.
* Fixes logged user initial user menu.
* Fixes reset password links in the user email when a librarian create a
patron. Closes: rero#608.
* Forces instance jinja templates to be loaded before all other
templates.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Nov 8, 2019
@jma
instance: fix several bugs
60f348a 
* Fixes item types type validation.
* Fixes validation message for patron phone number.
* Adds opening hours to the library of the 3th organisation.
* Fixes document detailed view for patrons with organisation without
pickup locations. Closes: rero#598.
* Fixes import document using EAN from the BNF server. Closes: rero#607.
* Improves logs to BNF document importation.
* Fixes logged user initial user menu.
* Fixes reset password links in the user email when a librarian create a
patron. Closes: rero#608.
* Forces instance jinja templates to be loaded before all other
templates.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Nov 11, 2019
@jma
instance: fix several bugs
33ab836 
* Fixes item types type validation.
* Fixes validation message for patron phone number.
* Adds opening hours to the library of the 3th organisation.
* Fixes document detailed view for patrons with organisation without
pickup locations. Closes: rero#598.
* Fixes import document using EAN from the BNF server. Closes: rero#607.
* Improves logs to BNF document importation.
* Fixes logged user initial user menu.
* Fixes reset password links in the user email when a librarian create a
patron. Closes: rero#608.
* Forces instance jinja templates to be loaded before all other
templates.
* Makes exception variable more explicit e -> error.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
iGormilhit pushed a commit that referenced this issue Nov 11, 2019
@jma
instance: fix several bugs
27c20bd 
* Fixes item types type validation.
* Fixes validation message for patron phone number.
* Adds opening hours to the library of the 3th organisation.
* Fixes document detailed view for patrons with organisation without
pickup locations. Closes: #598.
* Fixes import document using EAN from the BNF server. Closes: #607.
* Improves logs to BNF document importation.
* Fixes logged user initial user menu.
* Fixes reset password links in the user email when a librarian create a
patron. Closes: #608.
* Forces instance jinja templates to be loaded before all other
templates.
* Makes exception variable more explicit e -> error.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma closed this as completed in 5ea94b4 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
bug (critical) Blocking issue, should be fixed ASAP f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jma @iGormilhit @pronguen