-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine.io integration #575
Comments
Yup it looks like if I manually go add a regex the problem is solved. There should be an option to ignore certain regex patterns instead of manually hardcoding them into the library IMO |
Temporary fix (for anyone else who has the same problem): Bind to server.server which bypasses restify completely |
Looks like we need to do a better job of allowing web socket based routes, and not require hard coding of urls in order to get around the pre processing of request attributes. Will add this to the backlog. |
This appears to have been resolved in #669 If I'm missing a nuance here, please call me out on it! We can re-open this issue and discuss! |
Closes: #289 #381 #474 #575 #790 #633 #717 #576 #576 #909 #875 #860 #853 #850 #829 #813 #801 #921 #1101 #1019 #989 #632 #708 #737 #859 #1326 #1327 #927 #1099 #1068 #1040 #1035 #957 #948 #1134 #1136 #1183 #1206 #1286 #1323 > Note: this issue closes _but does not resolve_ the issues listed, we are just tracking them in another medium
I'm trying to use engine.io with restify and can't seem to get it to work. It seems like restify is messing with the requests that come in even though I have no handlers set up for them.
I see there is a special case for socket.io to make restify leave requests for it alone. https://github.com/mcavage/node-restify/blob/master/lib/server.js#L250
The text was updated successfully, but these errors were encountered: