Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing next.ifError, or changing it's underlying implementation #875

Closed
DonutEspresso opened this issue Aug 4, 2015 · 3 comments
Closed

Consider removing next.ifError, or changing it's underlying implementation #875

DonutEspresso opened this issue Aug 4, 2015 · 3 comments

Comments

@DonutEspresso
Copy link
Member

We've gone back and forth on this a bit, but it may be worth considering removing this API due to it causing a lot of confusion. Certainly, it is partially a documentation problem.

Because it also currently relies on throwing in the domain, it doesn't work with Promise or Observable chains.
@DonutEspresso DonutEspresso added this to the Release: 4.0.x milestone Aug 4, 2015
@jishi jishi mentioned this issue Dec 3, 2015
Closed
@karthikiyengar
Copy link
Contributor

The API is pretty confusing to me. It simply seems to be throwing the exception. What if I want to send the error back as JSON? Do I implement that in uncaughtException?

@DonutEspresso
Copy link
Member Author

@karthikiyengar You can use res.send(err) to send the error back in JSON.

@retrohacker retrohacker removed this from the Release: 4.0.x milestone Apr 29, 2017
retrohacker pushed a commit that referenced this issue Apr 29, 2017
Create FEATURE_REQUESTS.md
553c95a 
Closes:

#289
#381
#474
#575
#790
#633
#717
#576
#576
#909
#875
#860
#853
#850
#829
#813
#801
#921
#1101
#1019
#989
#632
#708
#737
#859
#1326
#1327
#927
#1099
#1068
#1040
#1035
#957
#948
#1134
#1136
#1183
#1206
#1286
#1323

> Note: this issue closes _but does not resolve_ the issues listed, we are just tracking them in another medium
@retrohacker retrohacker mentioned this issue Apr 29, 2017
Merged
@retrohacker
Copy link
Member

next.ifError is deprecated in the 5.x release: https://github.com/restify/node-restify/blob/5.x/lib/deprecationWarnings.js#L4-L17

@retrohacker retrohacker mentioned this issue May 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@retrohacker @DonutEspresso @karthikiyengar