Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router should use DFAs instead of an array for route lookups #850

Closed
yunong opened this issue Jun 26, 2015 · 2 comments
Closed

Router should use DFAs instead of an array for route lookups #850

yunong opened this issue Jun 26, 2015 · 2 comments

Comments

@yunong
Copy link
Member

yunong commented Jun 26, 2015

From when we were discussing this on HN, the router can actually use a DFA based approach such that url lookups are constant time n where n is the length of the url. http://www.colm.net/open-source/ragel/

Otherwise the current approach for routes with regexes means that we need to make an O(n) pass through all of the routes.

@yunong yunong added this to the Release: 4.0.x milestone Jun 26, 2015
@yunong
Copy link
Member Author

yunong commented Jun 26, 2015

Here's a good thread about how we might do this: https://news.ycombinator.com/item?id=8631370

@DonutEspresso
Copy link
Member

👍

@retrohacker retrohacker modified the milestone: Release: 4.0.x Apr 29, 2017
retrohacker pushed a commit that referenced this issue Apr 29, 2017
Closes:

#289
#381
#474
#575
#790
#633
#717
#576
#576
#909
#875
#860
#853
#850
#829
#813
#801
#921
#1101
#1019
#989
#632
#708
#737
#859
#1326
#1327
#927
#1099
#1068
#1040
#1035
#957
#948
#1134
#1136
#1183
#1206
#1286
#1323

> Note: this issue closes _but does not resolve_ the issues listed, we are just tracking them in another medium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants