Update to the master of pe-st #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the gpx and tcx endpoints to the new Garmin services url_gc_tcx_activity = 'https://connect.garmin.com/modern/proxy/download-service/export/tcx/activity/' url_gc_gpx_activity = 'https://connect.garmin.com/modern/proxy/download-service/export/gpx/activity/'
Update gcexport.py
The old endpoint ('activity-search-service-1.2') doesn't seem to
work anymore for more than 20 activities, but is still useful for
the result summary (total numbers of activities)
The new endpoint ('activitylist-service') has an almost
completely different JSON output, which hasn't been adapted yet.
Also explain limit_maximum
This an adaptation of commit 7b0fcc7 to the refactored code
- restored order for a dozen or so columns - timestamp format is almost RFC1123 as used by Garmin
Add activity detail example file corresponding to the other examples
This reverts commit 7f5ff09.
This reverts commit ea01363.
a lot lot doubled code in "def http_req()"
revert to original
If Garmin likes to call the device `fēnix` then so be it
The option `--count all` does work now, and the results of `-f json` for Python 2 and Python 3 are identical except for the precision of floating point numbers in the CSV
Recommended by @bartskowron, following the advice of https://legacy.python.org/dev/peps/pep-0394/
Suggested by Bart Skowron Co-Authored-By: Bart Skowron <233652+bartskowron@users.noreply.github.com>
Suggested by @telemaxx Co-Authored-By: telemaxx <6745th@web.de>
Now that properties file are read with `http_req_as_string`, the input parameters for `load_properties` are always proper strings and the special code for Python 3 is not needed anymore
Suggested by Bart Skowron for performance reasons Co-Authored-By: Bart Skowron <233652+bartskowron@users.noreply.github.com>
Suggested by Bart Skowron Co-Authored-By: Bart Skowron <233652+bartskowron@users.noreply.github.com>
...to determine the Python version Suggested by Bart Skowron Co-Authored-By: Bart Skowron <233652+bartskowron@users.noreply.github.com>
Also integrated unit tests for `resolve_path` to the other unit tests (using pytest) Fixes #37 (subdir quit working after update)
Apparently Garmin changed the name in the original file format zips, which lead to files downloaded again and again, see issue #48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.