fix(toolchain): fix vergen_git2 -> vergen dependency #1983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
7339a06
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://53ce3dc3.rivet.pages.dev |
| Branch Preview URL: | https://01-30-fix-toolchain-fix-verg.rivet.pages.dev |
This was referenced Jan 30, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updated dependency from vergen_git2 to vergen across multiple packages to standardize build-time information generation.
- Modified
/packages/toolchain/toolchain/build.rsto usevergen::Emitterinstead ofvergen_git2 - Added
vergen = "9.0.4"dependency consistently across multiple packages including/packages/toolchain/cli/Cargo.tomland/packages/common/env/Cargo.toml - Simplified build script implementation by using
Emitter::default()which provides standard build information without explicit configuration
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
NathanFlurry
force-pushed
the
01-30-fix_toolchain_fix_vergen_git2_-_vergen_dependency
branch
from
e2ce96e to
11f7b5e
Compare
NathanFlurry
changed the base branch from
01-30-fix_frontend_packages_icons_fix_failling_to_install_rivet-gg_icons_when_fontawesome_token_is_not_provided
to
01-30-chore_flatten_all_.gitignores_in_to_root_merge_in_to_.dockerignore
This was referenced Jan 31, 2025
NathanFlurry
force-pushed
the
01-30-chore_flatten_all_.gitignores_in_to_root_merge_in_to_.dockerignore
branch
from
976fd2b to
ffca06a
Compare
NathanFlurry
force-pushed
the
01-30-fix_toolchain_fix_vergen_git2_-_vergen_dependency
branch
from
11f7b5e to
7339a06
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Merge activity
|
Merge activity
|
NathanFlurry
changed the base branch from
01-30-chore_flatten_all_.gitignores_in_to_root_merge_in_to_.dockerignore
to
graphite-base/1983
graphite-app
bot
deleted the
01-30-fix_toolchain_fix_vergen_git2_-_vergen_dependency
branch
This was referenced Feb 1, 2025
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes