Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix building toolchain #1996

Closed
wants to merge 13 commits into from
Closed

fix(ci): fix building toolchain #1996

wants to merge 13 commits into from

Conversation

NathanFlurry
Copy link
Member

Changes

This was referenced Feb 3, 2025
Closed
Closed
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Feb 3, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps[bot]
greptile-apps bot reviewed Feb 3, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Reorganized Node.js toolchain setup sequence in the release workflow to ensure proper initialization order.

  • Moved corepack enable after Node.js setup in setup, binaries, and docker jobs in .github/workflows/release.yaml
  • Ensures corepack (Node.js package manager tool) is enabled only after Node.js environment is properly initialized
  • Maintains consistent toolchain setup sequence across all build jobs

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@NathanFlurry NathanFlurry force-pushed the 02-03-fix_ci_fix_building_toolchain branch 2 times, most recently from ace3774 to ea6e7b8 Compare February 3, 2025 21:40
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: eed1b99
Status: ✅  Deploy successful!
Preview URL: https://b561ef0c.rivet.pages.dev
Branch Preview URL: https://02-03-fix-ci-fix-building-to.rivet.pages.dev

View logs

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3a44448
Status: ✅  Deploy successful!
Preview URL: https://d030ad77.rivet-hub-7jb.pages.dev
Branch Preview URL: https://02-03-fix-ci-fix-building-to.rivet-hub-7jb.pages.dev

View logs

@NathanFlurry NathanFlurry force-pushed the 02-03-fix_ci_fix_building_toolchain branch 4 times, most recently from 3de4cb0 to f7c29af Compare February 3, 2025 21:54
@NathanFlurry NathanFlurry force-pushed the 02-03-feat_hub_add_dedicated_name_column_for_actors_builds branch from 322d2c8 to 537f3d9 Compare February 3, 2025 22:43
@NathanFlurry NathanFlurry force-pushed the 02-03-fix_ci_fix_building_toolchain branch 4 times, most recently from 07c44f5 to 447bd52 Compare February 3, 2025 23:45
@NathanFlurry NathanFlurry force-pushed the 02-03-fix_ci_fix_building_toolchain branch 21 times, most recently from 42cffbb to 07979e2 Compare February 4, 2025 05:56
@NathanFlurry
chore: release 25.1.0-rc.2
d556449 
Release-As: 25.1.0-rc.2
@NathanFlurry NathanFlurry force-pushed the 02-03-fix_ci_fix_building_toolchain branch from 07979e2 to d556449 Compare February 4, 2025 05:57
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Feb 4, 2025 •
edited
Loading

Merge activity

  • Feb 4, 1:42 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 4, 1:43 AM EST: CI is running for this PR on a draft PR: #1999
  • Feb 4, 1:44 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1999.

graphite-app bot pushed a commit that referenced this pull request Feb 4, 2025
@NathanFlurry
fix(ci): fix building toolchain (#1996)
94a3bf2 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Feb 4, 2025
@graphite-app graphite-app bot deleted the 02-03-fix_ci_fix_building_toolchain branch February 4, 2025 06:44
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NathanFlurry