Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(hub): update dev command to use turbo #1984

Closed
wants to merge 1 commit into from
Closed

chore(hub): update dev command to use turbo #1984

wants to merge 1 commit into from

Conversation

NathanFlurry
Copy link
Member

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f856c4
Status: ✅  Deploy successful!
Preview URL: https://c545d63b.rivet-hub-7jb.pages.dev
Branch Preview URL: https://chore-hub-update-dev-command.rivet-hub-7jb.pages.dev

View logs

This was referenced Jan 31, 2025
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Jan 31, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Jan 31, 2025
Closed
greptile-apps[bot]
greptile-apps bot reviewed Jan 31, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates the development command in the hub README to use Turborepo, but introduces potential workflow inconsistencies.

  • Mismatch between frontend/apps/hub/README.md command yarn dlx turbo dev and existing package.json script definition
  • Missing Turborepo configuration files needed to support this change
  • Consider updating package.json scripts to align with new Turbo workflow or reverting README change

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

frontend/apps/hub/README.md
@@ -7,7 +7,7 @@
```bash
cd frontend/apps/hub
yarn install
yarn dev
yarn dlx turbo dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Using 'yarn dlx' to run turbo on every dev command is inefficient. If turbo is needed, it should be added as a devDependency.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f856c4
Status: ✅  Deploy successful!
Preview URL: https://6d03956f.rivet.pages.dev
Branch Preview URL: https://chore-hub-update-dev-command.rivet.pages.dev

View logs

@NathanFlurry NathanFlurry force-pushed the 01-30-fix_toolchain_fix_vergen_git2_-_vergen_dependency branch from 11f7b5e to 7339a06 Compare January 31, 2025 21:40
@NathanFlurry NathanFlurry force-pushed the chore_hub_update_dev_command_to_use_turbo branch from ec6a0e7 to 6f856c4 Compare January 31, 2025 21:40
@NathanFlurry NathanFlurry mentioned this pull request Jan 31, 2025
Closed
graphite-app bot pushed a commit that referenced this pull request Jan 31, 2025
@NathanFlurry
chore(hub): update dev command to use turbo (#1984)
8914ef7 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jan 31, 2025 •
edited
Loading

Merge activity

  • Jan 31, 5:24 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 31, 5:24 PM EST: CI is running for this PR on a draft PR: #1989
  • Jan 31, 5:25 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1989.

@graphite-app graphite-app bot closed this Jan 31, 2025
@graphite-app graphite-app bot deleted the chore_hub_update_dev_command_to_use_turbo branch January 31, 2025 22:25
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Merged
This was referenced Feb 1, 2025
Open
Open
Open
Draft
Open
This was referenced Feb 3, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NathanFlurry