-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor issues in iCubGazeboV3_visuomanip
#176
Conversation
This is a draft PR for now. I will squash, and cancel irrelevant commits and select only unmerged commits. |
parent 530d017 author mebbaid <mohd-b-mohd@hotmail.com> 1669978606 +0100 committer mebbaid <mohd-b-mohd@hotmail.com> 1669978616 +0100 fix rebase conflict restore current version added missing velocityControlImplementationType param in config variables delete un-used config files add arm_no_hand config files to conf_manual Fix Hands weird position hand location fix fix r_hand collision group fix r_wrist_axis, play with camera sensors correct file name in l_eye sensor fix flipped pose of rgb sensors fix l_eye and r_eye pan axis Fix to make sure that ROS2 can find the iCub package (robotology#178)
Hi @xEnVrE , I was indeed confused why the file changed since the output of
with no local changes. Hopefully things should be ok now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are related to the network wrappers used, in general we should port all the models to the new one for supporting future versions of YARP
cc @traversaro
This is a PR that fixes
r_hand
collision parameters. reference issue Create iCubGazeboV3_visuomanip #169When finialized, this PR should close #169