Generate a window manually with GLFW when using irrlicht #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ergoCub seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
5 tasks
|
I realized now that the additional |
No problem! Anyhow I got rid of the Find script in S-Dafarra#1 , as it is not necessary in Ubuntu >= 20.04 . |
Made more clear that glfw instances counter is reduced only when closing the window. Anyhow, this was not an issue before thanks to the flag initialized that was set to false after the first call to close.
|
Ok, CI seems happy with the latest change. At this point, I think we need to ask help to @antonellopaolino to check if this new version of iDynTree does not interfere with his visualization workflow on Windows. For doing that, I already prepared some binaries at conda-forge/idyntree-feedstock#59 . However, there is a binary for each different version of Python, so to minimize the changes, I would like to ask to @antonellopaolino to provide us the output of |
|
Hi, @traversaro! This is the output of the |
|
Actually I probably underestimated the effort for this test. The problem is that we have the binary corresponding to this PR in idyntree, but we do not have the corresponding |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1070
I have tested it on Ubuntu 20 and on Windows 11 with a fresh installation and it seems to work. On Windows it works only when using SDL.
I needed to add a good amount of code to process the mouse inputs since with the external window,
irrlichtwas not detecting the events anymore.