-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement KinDynComputations::getCentroidalTotalMomentumJacobian() method #706
Conversation
The test that I've developed is failing on macOS. Since I don't have an apple machine I don't know how to find the bug. Any hints? |
…entroidalTotalMomentumJacobian
f9df8a0 fixes the problems on macOS. The PR is now ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment.
Small note: the current |
@Yeshasvitvs as I guess you were interested in this, feel free to check this PR as well! |
For the time being, I don't need this feature. Probably @Giulero @gabrielenava or @CarlottaSartore may need it in the next future |
@traversaro, regarding the |
Use |
Thanks a lot @GiulioRomualdi ! Let me know if you prefer to curate the commit yourself, or if it is ok that I merge with squash. |
Merge with squash it's ok with me. Thank you! |
In the iRonCub team we use an homemade centroidal momentum matrix block which is actually overcomplicated for the task, but for the moment it works. Also at the moment we use iDynTree in So it is ok to wait for August for what concerns iRonCub team. |
Thanks @GiulioRomualdi ! |
I do not see a problem for me to stay in devel rather than Master! Thank you @GiulioRomualdi |
This PR introduces the
getCentroidalTotalMomentumJacobian()
function inKinDynComputations
class.I also wrote a simple test to spot some bugs in the method
Associated issue robotology/wb-toolbox#20
cc @traversaro @robotology/iit-dynamic-interaction-control