Reflect matlab-whole-body-simulator#49 (removal of dependency from +wbc) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It makes sense to ad also @Giulero as a reviewer since he's already testing the controllers used on ironCub against the replacement of the "Holder" blocks. |
|
This branch will need to be rebased on top of |
|
@nunoguedelha I tested the |
traversaro
approved these changes
May 21, 2021
Great @Giulero , regarding the tests it's enough. Thanks! |
Giulero
approved these changes
May 22, 2021
…mulator/pull/49 - Full dependency PR link: ami-iit/matlab-whole-body-simulator#49
…ulator - Restore the link of the 'holder' blocks in the controller model to the WBToolbox (utilities) library -> after the new holder implementation was (robotology/wb-toolbox#211). - Remove the 'holder' block (not required anymore) from the 'utilityBlocks_lib.slx' library.
…ntrolBalancingWithSimu.mdl' model
- Converted boolean flags to enumerations. - Introduced None/Warning/EmergencyStop choices.
nunoguedelha
force-pushed
the
fix/reflect-mwbs#49-remove-dependency-from-wbc
branch
from
142a0b5 to
258bced
Compare
|
Merged. CC @gabrielenava |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are:
+wbc)WBToolbox (utilities) library -> after the new holder implementation was
(Re-implement the Holder block to make it compatible with code generation and 'treat as atomic unit' wb-toolbox#211).
library.