Remove dependency from whole-body-controllers #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to new @utils class - The methods H2Rp, Rp2H, exponentialMap are static. - The motivation of moving those utilities out of the class `State` was that they might be used by other classes and are not specific to the class `State`. - Using here a class instead of a package allows to control the access to the defined methods.
… on '+wbc' library
…ed in separate file This error occurs when we are using code generation: - A static class method is defined in a separate script file. - In such case the script length supported in code generation is limited Simulink error is: Simulink encountered an error while generating code through CGXE Infrastructure 'in CGXE: 'coverage/eml_code_coverage.cpp' line '1018': 'In fill_in_if_info: Assertion failed: endExprIdx < scriptStrLen' Refer to #48 for further details.
traversaro
approved these changes
May 15, 2021
nunoguedelha
force-pushed
the
fix/remove-dependency-from-wbc
branch
from
17597b2 to
551ecd8
Compare
|
Sorry @traversaro , if I asked you for review 2 days ago, it was a mistake, the PR was still in draft. It is ready now, with the README updates. |
traversaro
approved these changes
May 17, 2021
- Remove dependency on 'whole-body-controllers'. - Add 'Binary Installation' section. This section includes the one line installer and the procedure describing the installation of conda robotology package matlab-whole-body-simulator. - Add 'Source Installation' section. - Add installation details guides in 'doc' folder.
nunoguedelha
force-pushed
the
fix/remove-dependency-from-wbc
branch
from
551ecd8 to
2a553ba
Compare
|
Actually, this was branched out of |
Ok for me. |
nunoguedelha
added a commit
to robotology/whole-body-controllers
that referenced
this pull request
May 18, 2021
…mulator/pull/49 - Full dependency PR link: ami-iit/matlab-whole-body-simulator#49
This was referenced May 18, 2021
nunoguedelha
added a commit
to robotology/whole-body-controllers
that referenced
this pull request
May 22, 2021
…mulator/pull/49 - Full dependency PR link: ami-iit/matlab-whole-body-simulator#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #46 .
Also updates the READMEs w.r.t. those changes and w.r.t. the simplified installation using Conda packages. Refer to https://github.com/dic-iit/element_software-engineering/issues/24#issuecomment-839914872.