Support calling a method on an object. #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genevieve
commented
Sep 1, 2021
genevieve
commented
Sep 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 96.99% 97.10% +0.11%
==========================================
Files 12 12
Lines 466 484 +18
==========================================
+ Hits 452 470 +18
Misses 9 9
Partials 5 5
Continue to review full report at Codecov.
|
genevieve
force-pushed
the
gl-objmethodcall
branch
from
fbc42c1 to
e7e17fb
Compare
genevieve
force-pushed
the
gl-objmethodcall
branch
from
6e1c766 to
e8c4d2b
Compare
dylanahsmith
reviewed
Sep 3, 2021
genevieve
commented
Sep 3, 2021
| @@ -26,7 +26,7 @@ func (fn *Function) Call(args ...Valuer) (*Value, error) { | |||
| argptr = (*C.ValuePtr)(unsafe.Pointer(&cArgs[0])) | |||
| } | |||
| fn.ctx.register() | |||
| rtn := C.FunctionCall(fn.ptr, C.int(len(args)), argptr) | |||
| rtn := C.FunctionCall(fn.ptr, fn.ctx.iso.undefined.ptr, C.int(len(args)), argptr) | |||
added 3 commits
September 8, 2021 10:19
- Besides verifying that the obj.Get returns the err properly, we also want to test that fnVal.AsFunction returns the err properly when something is not a function
dylanahsmith
force-pushed
the
gl-objmethodcall
branch
from
aa8c097 to
c8cf319
Compare
- Add back test for methodcall on not-a-function
dylanahsmith
reviewed
Sep 8, 2021
dylanahsmith
force-pushed
the
gl-objmethodcall
branch
from
c8cf319 to
aa2a8f5
Compare
dylanahsmith
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension of #159 to fix #156
#159 (comment)
Builds on #162