Expose null and undefined constant values #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 96.94% 96.99% +0.05%
==========================================
Files 12 12
Lines 458 466 +8
==========================================
+ Hits 444 452 +8
Misses 9 9
Partials 5 5
Continue to review full report at Codecov.
|
genevieve
approved these changes
Sep 3, 2021
genevieve
pushed a commit
to Shopify/v8go
that referenced
this pull request
Sep 3, 2021
genevieve
pushed a commit
to Shopify/v8go
that referenced
this pull request
Sep 3, 2021
dylanahsmith
force-pushed
the
null-undefined-funcs
branch
from
9440663 to
26b531d
Compare
dylanahsmith
pushed a commit
to Shopify/v8go
that referenced
this pull request
Sep 8, 2021
dylanahsmith
pushed a commit
to Shopify/v8go
that referenced
this pull request
Sep 8, 2021
dylanahsmith
pushed a commit
to Shopify/v8go
that referenced
this pull request
Sep 8, 2021
dylanahsmith
pushed a commit
to Shopify/v8go
that referenced
this pull request
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #162
cc @genevieve
Currently, there is no simple way of getting
nullorundefinedJS values from v8go. There are workarounds like running a script to get these values, but this shouldn't be necessary.For instance, this would be useful in #160 for explicitly passing the
undefinedvalue as an explicit function call receiver