Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value.SameValue(otherValue) function #162

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

dylanahsmith
Copy link
Collaborator

When comparing objects, it would be useful to be able to test that the objects are the same and don't just have the same data, so I exposed v8::Value::SameValue

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #162 (69ec10f) into master (9ec924d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 69ec10f differs from pull request most recent head 4f1b761. Consider uploading reports for the commit 4f1b761 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   96.93%   96.94%           
=======================================
  Files          12       12           
  Lines         457      458    +1     
=======================================
+ Hits          443      444    +1     
  Misses          9        9           
  Partials        5        5           
Impacted Files Coverage Δ
function_template.go 100.00% <100.00%> (ø)
value.go 97.54% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec924d...4f1b761. Read the comment docs.

Copy link
Owner

@rogchap rogchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good.

@dylanahsmith dylanahsmith merged commit a05dd22 into rogchap:master Sep 8, 2021
@dylanahsmith dylanahsmith deleted the same-value branch September 8, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants