Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port TransmissionLoader from ROS Noetic over to ROS2 #599

Closed
3 tasks done
bmagyar opened this issue Dec 26, 2021 · 5 comments · Fixed by #633
Closed
3 tasks done

Port TransmissionLoader from ROS Noetic over to ROS2 #599

bmagyar opened this issue Dec 26, 2021 · 5 comments · Fixed by #633
Assignees
@VX792
Labels
enhancement good second issue

Comments

@bmagyar
Copy link
Member

bmagyar commented Dec 26, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, transmissions can only be used when one instantiates them by hand in the hardware component. In ROS1, one could add the requested transmissions to the xml and their parameters and have the transmission loader automatically take care of creating the right instances and connecting them to where they have to.

Describe the solution you'd like
TransmissionInfo can be found here.

For examples of configuring transmissions, look for <transmission in this file.

The recommended PRs to solve this issue are:

  • basic structure for TransmissionLoader and porting the SimpleTransmissionLoader plus tests for SimpleTransmissionLoader
  • DifferentialTransmissionLoader plus tests for DifferentialTransmissionLoader
  • FourBarLinkageTransmissionLoader plus tests for FourBarLinkageTransmissionLoader
@bmagyar
Copy link
Member Author

bmagyar commented Dec 26, 2021

Ping @VX792 please acknowledge you saw this ;)

@VX792
Copy link
Contributor

VX792 commented Dec 26, 2021 •
edited
Loading

I did! :D
I will begin working on the task on Tuesday

@bmagyar
Copy link
Member Author

bmagyar commented Dec 27, 2021

Thanks, with the response I could assign the issue to you ;)

@bmagyar bmagyar moved this to Todo in Roadmap / Features Dec 27, 2021
@bmagyar bmagyar moved this from Todo to In Progress in Roadmap / Features Dec 27, 2021
@bmagyar bmagyar changed the title Port TransmissionLoader from ROS Noetic over to ROS2 Port SimpleTransmissionLoader from ROS Noetic over to ROS2 Dec 27, 2021
@bmagyar bmagyar changed the title Port SimpleTransmissionLoader from ROS Noetic over to ROS2 Port TransmissionLoader from ROS Noetic over to ROS2 Dec 27, 2021
@VX792 VX792 mentioned this issue Jan 31, 2022
Merged
@destogl destogl linked a pull request Feb 1, 2022 that will close this issue
Port transmission loader plugins #633
Merged
Repository owner moved this from In Progress to Done in Roadmap / Features Feb 16, 2022
@wmmc88
Copy link
Contributor

wmmc88 commented Feb 16, 2022

#633 only resolves simple transmissions, right? The rest of this issue isn't resolved yet.

@bmagyar bmagyar reopened this Feb 17, 2022
@bmagyar
Copy link
Member Author

bmagyar commented Feb 17, 2022

That is correct, I'll tick off the first item on the list ;)

@bmagyar bmagyar moved this from Done to In Progress in Roadmap / Features Feb 25, 2022
@VX792 VX792 mentioned this issue Mar 1, 2022
Merged
@bmagyar bmagyar moved this from In Progress to Done in Roadmap / Features May 17, 2022
@bmagyar bmagyar closed this as completed May 17, 2022
pac48 pushed a commit to pac48/ros2_control that referenced this issue Jan 26, 2024
@mergify
switch from dash to underscore in setup.cfg (ros-controls#595) (ros-c…
5f3a471 
…ontrols#599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VX792 VX792

Labels
enhancement good second issue
Projects
Roadmap / Features
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port transmission loader plugins VX792/ros2_control
3 participants
@bmagyar @wmmc88 @VX792