feat: add utils file that includes a python color class #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
reviewed
Dec 18, 2021
bmagyar
reviewed
Dec 18, 2021
|
Heads up @destogl , this PR removes ament auto lint from controller_manager |
bmagyar
approved these changes
Dec 18, 2021
bmagyar
requested changes
Dec 26, 2021
There was a problem hiding this comment.
Ok sorry @fmros but I think the instructions were wrong on the original issue.
I don't think that a new utils file is a good pattern we want to follow nor that it's helpful to hardcode those values in a new file.
Same stackoverflow post, here's a whole bunch of packages doing something similar:
https://stackoverflow.com/a/68428529
Is there one with these things defined that we could use instead of having to re-define them?
pac48
pushed a commit
to pac48/ros2_control
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #564