Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add debian source build job #1310

Merged
merged 16 commits into from
Jan 23, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jan 17, 2024

This adds a new CI workflow for building stuff on debian (debian11 for humble+iron, debian12 for rolling, as stated in REP-200).

  • I had to exclude msg packages, because the ament_lint fails, maybe some issue with any python package version. see TypeError on debian11 ament/ament_lint#468
  • I excluded also rqt_controller_manager (no build of rqt etc on debian image)

@bmagyar If this is all approved I'd happy to transfer https://github.com/christophfroehlich/ros2_debian to ros-controls.
btw I tested the humble workflow with #1315

@christophfroehlich christophfroehlich marked this pull request as ready for review January 18, 2024 09:30
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51ff9ce) 48.02% compared to head (1198366) 48.01%.

❗ Current head 1198366 differs from pull request most recent head 755a38f. Consider uploading reports for the commit 755a38f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
- Coverage   48.02%   48.01%   -0.02%     
==========================================
  Files          41       41              
  Lines        3525     3526       +1     
  Branches     1912     1913       +1     
==========================================
  Hits         1693     1693              
  Misses        442      442              
- Partials     1390     1391       +1     
Flag Coverage Δ
unittests 48.01% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

christophfroehlich and others added 2 commits January 20, 2024 20:09
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
@bmagyar
Copy link
Member

bmagyar commented Jan 21, 2024

I think the same changes could the applied to the iron and rolling branches. Including using the file from the checkout and not the network resource.

@christophfroehlich
Copy link
Contributor Author

I think the same changes could the applied to the iron and rolling branches. Including using the file from the checkout and not the network resource.

sure, I'll also update that for the RHEL workflows

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Jan 22, 2024
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit 2e0f841 into ros-controls:master Jan 23, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Jan 23, 2024
mergify bot pushed a commit that referenced this pull request Jan 23, 2024
destogl pushed a commit that referenced this pull request Jan 23, 2024
(cherry picked from commit 2e0f841)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
destogl pushed a commit that referenced this pull request Jan 23, 2024
(cherry picked from commit 2e0f841)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@christophfroehlich christophfroehlich deleted the ci_debian branch January 23, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants