-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Hardware Components #1567
Async Hardware Components #1567
Conversation
This pull request is in conflict. Could you fix it @saikishor? |
7b96ec2
to
077b4cf
Compare
Resolved conflicts! |
This pull request is in conflict. Could you fix it @saikishor? |
077b4cf
to
9ace07b
Compare
This pull request is in conflict. Could you fix it @saikishor? |
4927ceb
to
ba30771
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1567 +/- ##
==========================================
+ Coverage 87.73% 88.13% +0.40%
==========================================
Files 122 121 -1
Lines 13010 13120 +110
Branches 1165 1177 +12
==========================================
+ Hits 11414 11563 +149
+ Misses 1165 1124 -41
- Partials 431 433 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This pull request is in conflict. Could you fix it @saikishor? |
fdeb59e
to
091ebad
Compare
091ebad
to
9180500
Compare
9180500
to
82b33ba
Compare
82b33ba
to
f6a2d15
Compare
f6a2d15
to
68c62fd
Compare
00870ca
to
ff7ef87
Compare
443451e
to
b2eb11b
Compare
…omponent interfaces
…and write async triggering
b2eb11b
to
56d9cc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I overseeing it, or is there some documentation missing? ;)
The parameters
<ros2_control name="TestActuatorHardware" type="actuator" is_async="true" thread_priority="30">
should be documented somewhere, and release notes would be great, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
@christophfroehlich the extra docs will go into a new PR |
Needs : ros-controls/realtime_tools#168
Fixes: #1954
This is to move towards the new async handling approach that we have done in a different PR also for the controllers.