Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Hardware Components #1567

Merged

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Jun 13, 2024

Needs : ros-controls/realtime_tools#168

Fixes: #1954

This is to move towards the new async handling approach that we have done in a different PR also for the controllers.

@saikishor saikishor marked this pull request as ready for review June 17, 2024 17:18
Copy link
Contributor

mergify bot commented Jun 25, 2024

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor force-pushed the async_hardware_components branch from 7b96ec2 to 077b4cf Compare June 25, 2024 13:45
@saikishor
Copy link
Member Author

Resolved conflicts!

Copy link
Contributor

mergify bot commented Jul 8, 2024

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor force-pushed the async_hardware_components branch from 077b4cf to 9ace07b Compare July 8, 2024 20:21
@saikishor saikishor added this to the Pre-Jazzy (Feb.'24) milestone Jul 17, 2024
Copy link
Contributor

mergify bot commented Jul 21, 2024

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor force-pushed the async_hardware_components branch from 4927ceb to ba30771 Compare July 21, 2024 18:38
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 93.29897% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.13%. Comparing base (7374c43) to head (56d9cc3).

Files with missing lines Patch % Lines
.../include/hardware_interface/actuator_interface.hpp 85.71% 3 Missing and 2 partials ⚠️
...ce/include/hardware_interface/system_interface.hpp 85.71% 3 Missing and 2 partials ⚠️
hardware_interface/src/resource_manager.cpp 66.66% 2 Missing ⚠️
hardware_interface/src/component_parser.cpp 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1567      +/-   ##
==========================================
+ Coverage   87.73%   88.13%   +0.40%     
==========================================
  Files         122      121       -1     
  Lines       13010    13120     +110     
  Branches     1165     1177      +12     
==========================================
+ Hits        11414    11563     +149     
+ Misses       1165     1124      -41     
- Partials      431      433       +2     
Flag Coverage Δ
unittests 88.13% <93.29%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/controller_manager/controller_manager.hpp 100.00% <ø> (ø)
controller_manager/src/controller_manager.cpp 76.08% <ø> (-0.31%) ⬇️
controller_manager/src/ros2_control_node.cpp 66.03% <ø> (-0.63%) ⬇️
...rface/include/hardware_interface/hardware_info.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/sensor_interface.hpp 95.38% <100.00%> (+1.38%) ⬆️
hardware_interface/src/actuator.cpp 80.66% <100.00%> (ø)
hardware_interface/src/sensor.cpp 76.03% <100.00%> (ø)
hardware_interface/src/system.cpp 80.66% <100.00%> (ø)
hardware_interface/test/test_component_parser.cpp 98.93% <100.00%> (+0.03%) ⬆️
...e_interface_testing/test/test_resource_manager.cpp 99.46% <100.00%> (+0.06%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Aug 26, 2024

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor force-pushed the async_hardware_components branch from fdeb59e to 091ebad Compare August 26, 2024 14:29
@saikishor saikishor force-pushed the async_hardware_components branch from 091ebad to 9180500 Compare September 17, 2024 20:45
@saikishor saikishor force-pushed the async_hardware_components branch from 9180500 to 82b33ba Compare September 26, 2024 20:39
@saikishor saikishor force-pushed the async_hardware_components branch from 82b33ba to f6a2d15 Compare October 9, 2024 07:31
@saikishor saikishor force-pushed the async_hardware_components branch from f6a2d15 to 68c62fd Compare October 27, 2024 18:26
@saikishor saikishor force-pushed the async_hardware_components branch from 00870ca to ff7ef87 Compare November 25, 2024 22:07
@saikishor saikishor force-pushed the async_hardware_components branch from 443451e to b2eb11b Compare December 4, 2024 12:44
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I overseeing it, or is there some documentation missing? ;)
The parameters
<ros2_control name="TestActuatorHardware" type="actuator" is_async="true" thread_priority="30">
should be documented somewhere, and release notes would be great, too.

bmagyar
bmagyar previously approved these changes Dec 19, 2024
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bmagyar
Copy link
Member

bmagyar commented Dec 19, 2024

@christophfroehlich the extra docs will go into a new PR

@bmagyar bmagyar merged commit 612b30b into ros-controls:master Dec 19, 2024
20 of 26 checks passed
@saikishor saikishor deleted the async_hardware_components branch December 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing command switch for async hardware components
3 participants