Fix CI and deduplicate CI code #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Karsten1987
approved these changes
Jul 17, 2019
|
thanks @mikaelarguedas |
destogl
referenced
this pull request
in StoglRobotics-forks/ros2_control
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening for visibility and start discussion:
When developing
ros2cifor some of my repos, @Karsten1987 mentioned there would be value for other projects such as this one to leverage a common docker code for the CI part.osrf now provides some docker images intended for ci use:
osrf/ros2:develthat contains the development tools andosrf/ros2:nightlythat contains the tools + the nightly build of the ros2.repos file.Switching to these images should fix broken CI here as the images have already been updated to use the new ROS keys.
I open this PR to see if
ros2cican be a drop in replacement and if there is interest to use it in this proect. Otherwise it is totally viable to update CI here to just use theosrf/ros2docker images directly.Related discussions for reference: