Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Reviewer Lottery: Use contains() in if rule #401

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport iron

Copy link
Contributor

mergify bot commented Dec 24, 2023

backport iron

✅ Backports have been created

@christophfroehlich
Copy link
Contributor Author

I found out why it did not work earlier: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does. This prevents execution of unsafe code from the head of the pull request that could alter your repository or steal any secrets you use in your workflow. This event allows your workflow to do things like label or comment on pull requests from forks. Avoid using this event if you need to build or run code from the pull request.

@christophfroehlich christophfroehlich merged commit 91d9281 into ros-controls:master Dec 24, 2023
14 checks passed
@christophfroehlich christophfroehlich deleted the ci/reviewer_lottery_contains branch December 24, 2023 09:38
mergify bot pushed a commit that referenced this pull request Dec 24, 2023
christophfroehlich added a commit that referenced this pull request Dec 24, 2023
(cherry picked from commit 91d9281)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant