Refactor logging (backport #543) #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor logging for example 1 - 6 * Update logger for remaining examples * Revert change to copyright * Revert "Reduce update rate to avoid clogging the log" This reverts commit 10f2e22. * Don't use throttling for example_6 * Update example_1/doc/userdoc.rst Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> * Update example_2/doc/userdoc.rst Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> * Updating docs * Merge into one logging statement * Remove throttled logging from example_14 * Apply suggestions from code review Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> --------- Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
github-actions
bot
requested review from
arne48,
DasRoteSkelett,
destogl,
mamueluth,
mcbed,
peterdavidfagan and
saikishor
|
@Mergifyio backport iron |
✅ Backports have been created
|
saikishor
requested changes
Nov 13, 2024
| data.str().c_str()); | ||
| send(sock_, data.str().c_str(), strlen(data.str().c_str()), 0); | ||
| ss << "Sending data command: " << data.str() << std::endl; | ||
| RCLCPP_INFO(get_logger(), ss.str().c_str()); |
There was a problem hiding this comment.
@christophfroehlich is throttle missing here?
| ss << "Got measured velocity " << measured_velocity << std::endl; | ||
| ss << "Got state " << hw_joint_state_ << " for joint '" << info_.joints[0].name << "'" | ||
| << std::endl; | ||
| RCLCPP_INFO(get_logger(), ss.str().c_str()); |
There was a problem hiding this comment.
@christophfroehlich here as well?
| ss << std::fixed << std::setprecision(2) << std::endl | ||
| << "\t" << hw_joint_state_ << " for joint '" << info_.joints[0].name << "'"; | ||
|
|
||
| RCLCPP_INFO(get_logger(), "%s", ss.str().c_str()); |
|
|
||
| RCLCPP_INFO(rclcpp::get_logger("RRBotModularJoint"), "Joints successfully written!"); | ||
| RCLCPP_INFO(get_logger(), "%s", ss.str().c_str()); |
|
@saikishor we have the problems with throttling in the plugins, remember #603 ;) |
saikishor
approved these changes
Nov 13, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#543 with additional local variables/methods for logging, which are available from jazzy on only.