Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of register_controller macro #11

Merged

Conversation

jordan-palacios
Copy link
Member

ros-controls/ros2_control#41 breaks ros2_controllers master branch. This PR should be merged after ros-controls/ros2_control#41 is accepted.

@Karsten1987
Copy link
Contributor

@jordan-palacios I've rebased your branch here to kick off CI. See here: ros-controls/ros2_control#41 (comment)

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
CI ran here

@Karsten1987 Karsten1987 merged commit 95db98c into ros-controls:master Feb 11, 2020
@jordan-palacios jordan-palacios deleted the remove_register_controller branch February 12, 2020 08:47
henrygerardmoore pushed a commit to SchillingRobotics/ros2_controllers_schilling that referenced this pull request May 3, 2024
…te_reset_dofs_with_values

Use values, if present in reset dofs service, instead of fb to reset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants