Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Fix hold position mode with goal_time>0 #758

Merged
merged 10 commits into from
Sep 12, 2023

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Aug 24, 2023

  • In hold position mode with goal_time>0: If the JTC can't hold the position (wrong PID tuning, effort limit,..), then it might enter a loop setting a new hold position again and again. Fixes [JTC] Hold position & goal_time>0: Infinite loop #757
    I had to introduce a new class variable to know if we are in holding mode, which breaks ABI. This is also used for [JTC] Add time-out for trajectory interfaces #609 to avoid deadlocks with timeouts.
  • I improved the test criterion for the cases with no position command interface: We can check only with active PID mode if the correct position is held.
  • set_hold_position generated invalid trajectory messages (use validate_trajectory_msg(current_pose_msg); to test that). I changed that to have the correct fields after sampling (with spline and also none), acc. to the docs of the trajectory representation
  • set_hold_position should be now realtime-safe: there is no reason to do memory allocation now where DOF and interface types are fixed

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

This pull request is in conflict. Could you fix it @christophfroehlich?

@bmagyar bmagyar merged commit 66c5ac3 into ros-controls:master Sep 12, 2023
13 checks passed
@christophfroehlich christophfroehlich deleted the fix_set_hold_position branch September 12, 2023 10:25
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Oct 21, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Oct 21, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 11, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 15, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 17, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 27, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 29, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 30, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JTC] Hold position & goal_time>0: Infinite loop
2 participants