Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Continue with last trajectory-point on success #842

Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 16, 2023

As discussed in #811: Continue with last trajectory point on success, instead of hold-position from current state.

Closes #811 and closes #759.

@christophfroehlich christophfroehlich added the backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #842 (5d8142f) into master (3555685) will decrease coverage by 0.45%.
Report is 1 commits behind head on master.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   47.22%   46.77%   -0.45%     
==========================================
  Files          40       40              
  Lines        3636     3641       +5     
  Branches     1716     1719       +3     
==========================================
- Hits         1717     1703      -14     
- Misses        735      749      +14     
- Partials     1184     1189       +5     
Flag Coverage Δ
unittests 46.77% <33.33%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...jectory_controller/joint_trajectory_controller.hpp 0.00% <ø> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 48.89% <33.33%> (+0.91%) ⬆️

... and 2 files with indirect coverage changes

@bmagyar bmagyar merged commit e4f1700 into ros-controls:master Dec 1, 2023
13 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Dec 1, 2023
@christophfroehlich christophfroehlich deleted the jtc/continue_success branch December 1, 2023 14:00
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 1, 2023
christophfroehlich added a commit that referenced this pull request Dec 4, 2023
christophfroehlich added a commit that referenced this pull request Dec 5, 2023
christophfroehlich added a commit that referenced this pull request Dec 5, 2023
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 5, 2023
christophfroehlich added a commit that referenced this pull request Dec 9, 2023
christophfroehlich added a commit that referenced this pull request Jan 2, 2024
christophfroehlich added a commit that referenced this pull request Jan 12, 2024
christophfroehlich added a commit that referenced this pull request Feb 17, 2024
christophfroehlich added a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
2 participants