-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JTC] Backport recent changes #801
Conversation
2d3705e
to
0a54d8e
Compare
Hey Folks, Would be really helpful if we get this backport.. Does this need a review or something that I might probably help with? Need this one #558 specifically.. |
Reviews always help :) Feel free to clone the branch, test it with your setup, and leave your approval here! |
tested out #558 already.. I'm satisfied with the behavior. Will try to test the others too when I get some time. Thanks @christophfroehlich |
b5e0309
to
b0ea83f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## humble #801 +/- ##
=========================================
Coverage ? 44.79%
=========================================
Files ? 40
Lines ? 3710
Branches ? 1766
=========================================
Hits ? 1662
Misses ? 836
Partials ? 1212
Flags with carried forward coverage won't be shown. Click here to find out more. |
e7f7b3f
to
1d3f1e2
Compare
9c1cffc
to
17e44c6
Compare
This is big... Put it out of draft mode as if we leave it there it will never be merged |
…#613) * Add new test to ensure that controller goes into position holding when tolerances are violated * Hold position if goal_time is exceeded with topic interface * Fix hold on time-violation
* Simplify initialization of states * Rename read_state_from_hardware method * Don't set state_desired in on_activate --------- Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
* Fix dynamic reconfigure of tolerances * Fix static cast syntax
* Fix floating point comparison in JTC * Fix format --------- Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
493990d
to
41304df
Compare
Heads up @fmauch @RobertWilbrandt Just pushed a release to Humble without these changes. This will be included in the next release. Good news is that we do not intend to make any substantial changes to the JTC in Humble in the future. |
This PR includes backports of PRs for JTC (with fixed merge conflicts) in the correct order.
Besides updates to the tests and docs, this includes
start_with_holding
option #839 + [JTC] Continue with last trajectory-point on success #842allow_nonzero_velocity_at_trajectory_end
default false #834We decided backporting #558 (including its fixes) during a recent WG meeting. The others are optional but should not break anything (but avoid conflicts for future backports).
This PR should not be squashed maybe, but ff-merged on top of humble?! I could also make separate backport PRs, but this will take some time as they are depending on each other and are bugfixing earlier commits.