Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JTC] Tolerance tests + Hold on time violation #613

Merged
merged 8 commits into from
Aug 16, 2023
Merged

[JTC] Tolerance tests + Hold on time violation #613

merged 8 commits into from
Aug 16, 2023

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented May 14, 2023 •
edited
Loading

I realized that if using the topic interface: The current trajectory will never be stopped if the goal isn't reached within time.

New tests fix #407 but need

@christophfroehlich christophfroehlich mentioned this pull request May 14, 2023
Closed
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

This pull request is in conflict. Could you fix it @christophfroehlich?

@destogl destogl mentioned this pull request Jun 26, 2023
Closed
6 tasks
@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2023

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich marked this pull request as draft June 26, 2023 19:38
@christophfroehlich christophfroehlich force-pushed the jtc_tolerance_tests branch 3 times, most recently from 86c3b5d to 3497b88 Compare July 2, 2023 19:19
@christophfroehlich christophfroehlich mentioned this pull request Jul 3, 2023
Merged
12 tasks
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich changed the base branch from jtc-features to master July 18, 2023 11:37
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #613 (e6c6884) into master (e7f9962) will decrease coverage by 4.90%.
Report is 356 commits behind head on master.
The diff coverage is 25.91%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   35.78%   30.88%   -4.90%     
==========================================
  Files         189        7     -182     
  Lines       17570      832   -16738     
  Branches    11592      505   -11087     
==========================================
- Hits         6287      257    -6030     
+ Misses        994      133     -861     
+ Partials    10289      442    -9847
Flag Coverage Δ
unittests 30.88% <25.91%> (-4.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 11.11% <0.00%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 12.66% <7.81%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 47.13% <46.94%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich marked this pull request as ready for review August 16, 2023 06:21
@christophfroehlich
Copy link
Contributor Author

CI fails because of flaky JTC tests, not related to this PR

christophfroehlich and others added 2 commits August 16, 2023 15:57
@christophfroehlich @bmagyar
Update error message
0276512 
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
@christophfroehlich
Merge branch 'master' into jtc_tolerance_tests
446160c
@bmagyar bmagyar merged commit be36645 into ros-controls:master Aug 16, 2023
13 checks passed
@christophfroehlich christophfroehlich deleted the jtc_tolerance_tests branch August 16, 2023 15:06
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Oct 21, 2023
@christophfroehlich
[JTC] Tolerance tests + Hold on time violation (ros-controls#613)
41b0360 
* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
@christophfroehlich christophfroehlich mentioned this pull request Oct 21, 2023
Merged
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Oct 21, 2023
@christophfroehlich
[JTC] Tolerance tests + Hold on time violation (backport ros-controls…
90398df 
…#613)

* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 11, 2023
@christophfroehlich
[JTC] Tolerance tests + Hold on time violation (backport ros-controls…
e0a8946 
…#613)

* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 15, 2023
@christophfroehlich
[JTC] Tolerance tests + Hold on time violation (backport ros-controls…
f722e96 
…#613)

* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 17, 2023
@christophfroehlich
[JTC] Tolerance tests + Hold on time violation (backport ros-controls…
f475ec9 
…#613)

* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 27, 2023
@christophfroehlich
[JTC] Tolerance tests + Hold on time violation (backport ros-controls…
2d6c34d 
…#613)

* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 29, 2023
@christophfroehlich
[JTC] Tolerance tests + Hold on time violation (backport ros-controls…
377c2a3 
…#613)

* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 30, 2023
@christophfroehlich
[JTC] Tolerance tests + Hold on time violation (backport ros-controls…
f7abd0f 
…#613)

* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 5, 2023
@christophfroehlich
[JTC] Tolerance tests + Hold on time violation (backport ros-controls…
63ea018 
…#613)

* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
bmagyar pushed a commit that referenced this pull request Dec 6, 2023
@christophfroehlich @bmagyar
[JTC] Tolerance tests + Hold on time violation (backport #613)
8c715ac 
* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@jaron-l jaron-l Awaiting requested review from jaron-l

@mhubii mhubii Awaiting requested review from mhubii

@progtologist progtologist Awaiting requested review from progtologist

@VX792 VX792 Awaiting requested review from VX792

@anfemosa anfemosa Awaiting requested review from anfemosa

@homalozoa homalozoa Awaiting requested review from homalozoa

@mcbed mcbed Awaiting requested review from mcbed

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JTC] Add new test to ensure that controller goes into position holding when tolerances are violated
3 participants
@christophfroehlich @codecov-commenter @bmagyar