Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use link names in temperature messages #320

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Use link names in temperature messages #320

merged 2 commits into from
Jul 2, 2019

Conversation

fmauch
Copy link

@fmauch fmauch commented Jul 2, 2019

This resolves #315

@gavanderhoorn gavanderhoorn added the wrid19 World ROS-Industrial Day 2019 label Jul 2, 2019
miguelprada
miguelprada reviewed Jul 2, 2019
View reviewed changes
Copy link
Contributor

@miguelprada miguelprada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@gavanderhoorn
Copy link
Member

See mine: #315 (comment)

;)

gavanderhoorn
gavanderhoorn requested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could take a look at the suggestion?

Other than that this looks OK.

@miguelprada: would you agree with this in the end?

src/ros/rt_publisher.cpp Show resolved Hide resolved
include/ur_modern_driver/ros/rt_publisher.h Show resolved Hide resolved
@fmauch @gavanderhoorn
Added an explanation why link_names are used for temperature frame_id
b0e8f66 
Co-Authored-By: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
miguelprada
miguelprada approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@miguelprada miguelprada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think it makes sense. Good to merge if you want.

@gavanderhoorn
Copy link
Member

Just waiting for Travis now. Has been very slow today ..

@gavanderhoorn gavanderhoorn merged commit 048edd2 into ros-industrial-attic:kinetic-devel Jul 2, 2019
@gavanderhoorn
Copy link
Member

Thanks @fmauch 👍

@gavanderhoorn gavanderhoorn mentioned this pull request Jul 2, 2019
Closed
@fmauch fmauch mentioned this pull request Jul 2, 2019
Closed
@gavanderhoorn gavanderhoorn mentioned this pull request Nov 18, 2019
Open
@tassos tassos mentioned this pull request Aug 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn approved these changes

@miguelprada miguelprada miguelprada approved these changes

Assignees
No one assigned
Labels
wrid19 World ROS-Industrial Day 2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmauch @gavanderhoorn @miguelprada