-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a message concerning the robot information #2
Conversation
the goal is to mirror http://doc.aldebaran.com/2-1/naoqi/motion/tools-general-api.html?highlight=getrobotconfig#ALMotionProxy::getRobotConfig and probably add info over time (like serial number). |
Do we really need all these fields? For example a field has_laser and robot_model for Pepper are redundant, no? Similar issues for number of legs for pepper? According to naoqi there is 1 leg :) Why is arm_version a bool? Shouldn't it be a uint8 as well for iterating over VERSION_33, VERSION_40 etc ? |
@Karsten1987 , please comment in the file, it makes comments easier to track. |
for the laser, NAO can also have a laser on some prototypes. |
renamed a few things and added the service |
# Number of Arms : 0 or 2 | ||
int32 number_of_arms | ||
# Number of Hands: 0 or 2 | ||
int32 number_of_hands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have versions with arms but without hands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, I guess it was the case at some point ....
add a message concerning the robot information
comments anyone ?