Reclaim Our CI Coverage from the Lords of Painful Subtle Regressions …

…⚔️⚔️⚔️ (#3266) * test waypoint follower with composition off for logging * adding no composition to all system tests
ros-navigation · Nov 3, 2022 · 4bd3f73 · 4bd3f73
1 parent eafc751
commit 4bd3f73
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 0 deletions.
diff --git a/nav2_system_tests/src/behaviors/assisted_teleop/test_assisted_teleop_behavior_launch.py b/nav2_system_tests/src/behaviors/assisted_teleop/test_assisted_teleop_behavior_launch.py
@@ -78,6 +78,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': configured_params,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True'}.items()),
  ])
 

diff --git a/nav2_system_tests/src/behaviors/backup/test_backup_behavior_launch.py b/nav2_system_tests/src/behaviors/backup/test_backup_behavior_launch.py
@@ -78,6 +78,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': configured_params,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True'}.items()),
  ])
 

diff --git a/nav2_system_tests/src/behaviors/drive_on_heading/test_drive_on_heading_behavior_launch.py b/nav2_system_tests/src/behaviors/drive_on_heading/test_drive_on_heading_behavior_launch.py
@@ -78,6 +78,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': configured_params,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True'}.items()),
  ])
 

diff --git a/nav2_system_tests/src/behaviors/spin/test_spin_behavior_launch.py b/nav2_system_tests/src/behaviors/spin/test_spin_behavior_launch.py
@@ -78,6 +78,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': configured_params,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True'}.items()),
  ])
 

diff --git a/nav2_system_tests/src/behaviors/wait/test_wait_behavior_launch.py b/nav2_system_tests/src/behaviors/wait/test_wait_behavior_launch.py
@@ -78,6 +78,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': configured_params,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True'}.items()),
  ])
 

diff --git a/nav2_system_tests/src/costmap_filters/test_keepout_launch.py b/nav2_system_tests/src/costmap_filters/test_keepout_launch.py
@@ -118,6 +118,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': new_yaml,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True'}.items()),
 
  Node(

diff --git a/nav2_system_tests/src/costmap_filters/test_speed_launch.py b/nav2_system_tests/src/costmap_filters/test_speed_launch.py
@@ -116,6 +116,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': new_yaml,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True'}.items()),
  ])
 

diff --git a/nav2_system_tests/src/system/test_multi_robot_launch.py b/nav2_system_tests/src/system/test_multi_robot_launch.py
@@ -106,6 +106,7 @@ def generate_launch_description():
  'params_file': params_file,
  'bt_xml_file': bt_xml_file,
  'autostart': 'True',
+ 'use_composition': 'False',
  'use_remappings': 'True'}.items())
  ])
  nav_instances_cmds.append(group)

diff --git a/nav2_system_tests/src/system/test_system_launch.py b/nav2_system_tests/src/system/test_system_launch.py
@@ -96,6 +96,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': new_yaml,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True'}.items()),
  ])
 

diff --git a/nav2_system_tests/src/system/test_wrong_init_pose_launch.py b/nav2_system_tests/src/system/test_wrong_init_pose_launch.py
@@ -96,6 +96,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': new_yaml,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True',
  'use_composition': 'False'}.items()),
  ])

diff --git a/nav2_system_tests/src/system_failure/test_system_failure_launch.py b/nav2_system_tests/src/system_failure/test_system_failure_launch.py
@@ -86,6 +86,7 @@ def generate_launch_description():
  'use_sim_time': 'True',
  'params_file': new_yaml,
  'bt_xml_file': bt_navigator_xml,
+ 'use_composition': 'False',
  'autostart': 'True'}.items()),
  ])
 

diff --git a/nav2_system_tests/src/updown/test_updown_launch.py b/nav2_system_tests/src/updown/test_updown_launch.py
@@ -61,6 +61,7 @@ def generate_launch_description():
  os.path.join(launch_dir, 'bringup_launch.py')),
  launch_arguments={'map': map_yaml_file,
  'use_sim_time': 'True',
+ 'use_composition': 'False',
  'autostart': 'False'}.items())
 
  start_test = launch.actions.ExecuteProcess(

diff --git a/nav2_system_tests/src/waypoint_follower/test_case_py.launch b/nav2_system_tests/src/waypoint_follower/test_case_py.launch
@@ -79,6 +79,7 @@ def generate_launch_description():
  launch_arguments={
  'map': map_yaml_file,
  'use_sim_time': 'True',
+ 'use_composition': 'False',
  'params_file': new_yaml,
  'bt_xml_file': bt_navigator_xml,
  'autostart': 'True'}.items()),