usage of has_parameter() before declare_parameter()

[padhupradheep]

Bug report

Required Info:

• Operating System:
  • Ubuntu 20.04
• ROS2 Version:
  • Rolling
• Version or commit hash:
  • main
• DDS implementation:
  • does not matter

There are multiple files, that still checks for the availability of the parameter using has_parameter() even without the declaration, something similar to #2663

@SteveMacenski : I will do a PR with all the fixes, before end of this week.

[SteveMacenski]

I'd ask for them to be enumerated, but if its just a couple we can discuss over the PR. I just don't want to have you waste time if the fixes for some of them are non-trivial before discussing to make sure your understanding of their use are correct. The BT XML was an oversight, but I'd be surprised if there were many others like that. There are places we use has_parameter in a context where it would have been declared in another place, so I want to make sure I can give you any context for ones that are not as easy to track down but are there.

but if they're few and easy to fix, go ahead and we can talk over the PR 😄

[padhupradheep]

There are places we use has_parameter in a context where it would have been declared in another place

I actually missed this big time! You are right!