Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we move from intel/ros2_message_filters -> ros2/message_filters? #274

Closed
SteveMacenski opened this issue Oct 31, 2018 · 3 comments
Closed

Should we move from intel/ros2_message_filters -> ros2/message_filters? #274

SteveMacenski opened this issue Oct 31, 2018 · 3 comments
Assignees
@crdelsey
Labels
1 - High High Priority question Further information is requested
Milestone
December Crystal ...

Comments

@SteveMacenski
Copy link
Member

SteveMacenski commented Oct 31, 2018 •
edited
Loading

https://github.com/ros2/message_filters

If we actually need it, then someone at Intel needs to commit to adding the rosdep keys for it and bloom releasing it so we can build the anvigation2 stack in CI.
@SteveMacenski SteveMacenski added the question Further information is requested label Oct 31, 2018
@SteveMacenski SteveMacenski changed the title [Question] What does the intel ros2_message_filters do that tf2_ros versions dont? Should we move from intel/ros2_message_filters -> ros2/message_filters Nov 1, 2018
@SteveMacenski SteveMacenski changed the title Should we move from intel/ros2_message_filters -> ros2/message_filters Should we move from intel/ros2_message_filters -> ros2/message_filters? Nov 1, 2018
@mkhansenbot
Copy link
Collaborator

ros2/message_filters#13

@mkhansenbot
Copy link
Collaborator

@gaoethan - Is there any reason we can't replace intel/message_filters with ros2/message_filters when the PR above (#13) is merged?

@mkhansenbot mkhansenbot added the 1 - High High Priority label Nov 12, 2018
@mkhansenbot mkhansenbot added this to the December Crystal release milestone Nov 12, 2018
@gaoethan
Copy link

Actually, the current ros2/message_filters is derived from our intel/message_filters, we have already formally transferred our porting to ros2 community and maintain it as ros2/message_filters, so please use the ros2/message_filters now, thanks !

@crdelsey crdelsey mentioned this issue Dec 3, 2018
Merged
@crdelsey crdelsey self-assigned this Dec 3, 2018
ghost pushed a commit to logivations/navigation2 that referenced this issue Mar 7, 2022
@jplapp
Backup recovery both directions (ros-navigation#274)
38865ca 
* allow driving forwards in backup recovery

* backup: allow forward driving again (we could implement our own node to not have to modify this one)

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crdelsey crdelsey

Labels
1 - High High Priority question Further information is requested
Projects
None yet
Milestone
December Crystal release
Development

No branches or pull requests
4 participants
@mkhansenbot @SteveMacenski @gaoethan @crdelsey