Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motion Primitives should return failure if they would collide #899

Closed
ghost opened this issue Jun 28, 2019 · 1 comment
Closed

Motion Primitives should return failure if they would collide #899

ghost opened this issue Jun 28, 2019 · 1 comment
Assignees
@SteveMacenski
Labels
2 - Medium Medium Priority
Milestone
Eloquent (E Turtl...

Comments

@ghost
Copy link

ghost commented Jun 28, 2019

Bug report

PR #889 changed added support for collision checking to the motion primitives, however, they always return SUCCESS to a motion request, regardless of whether they successfully completed the action. They should return FAILURE if they failed to complete the action. The bt_navigator behavior tree needs to be updated to deal with this appropriately.
@ghost ghost added this to the E Turtle Release milestone Jul 8, 2019
@ghost ghost added the 2 - Medium Medium Priority label Jul 8, 2019
@SteveMacenski SteveMacenski self-assigned this Jul 30, 2019
@SteveMacenski SteveMacenski mentioned this issue Aug 5, 2019
Merged
@ghost ghost added for review and removed for review labels Oct 1, 2019
@ghost
Copy link
Author

ghost commented Oct 7, 2019

Duplicate of #1206

@ghost ghost marked this as a duplicate of #1206 Oct 7, 2019
@ghost ghost closed this as completed Oct 7, 2019
Forsyth-Creations pushed a commit to Forsyth-Creations/navigation2 that referenced this issue Feb 19, 2025
@christophfroehlich
Add tests for interface_configuration_type consistently (ros-naviga…
f2f36c0 
…tion#899)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SteveMacenski SteveMacenski

Labels
2 - Medium Medium Priority
Projects
None yet
Milestone
Eloquent (E Turtle) Release
Development

No branches or pull requests
1 participant
@SteveMacenski