-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback in navigation2 actions #1586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks for doing this Steve.
Co-Authored-By: Carl Delsey <1828778+cdelsey@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1586 +/- ##
=========================================
+ Coverage 38.21% 38.51% +0.3%
=========================================
Files 229 228 -1
Lines 11924 11976 +52
Branches 5240 5276 +36
=========================================
+ Hits 4557 4613 +56
+ Misses 3883 3836 -47
- Partials 3484 3527 +43
Continue to review full report at Codecov.
|
Basic Info
Description of contribution in a few bullet points
Added feedback to long running actions.
removed random crawl as it is still in nav2 experimental with the server
NavigateToPose; pose, time spent on task, number of recoveries executed, distance remaining
Follow path: Instantaneous speed, distance to goal in odom
Spin and backup: distance so far gone
Wait and compute path: none, as either has a while loop naturally conducive to feedback.
Description of documentation updates required from your changes
Future work that may be required in bullet points
This PR is also to gather reviews and feedback on other metrics you'd like to have included in the API.