-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a demo robot #241
Adding a demo robot #241
Conversation
Is this here because the |
@@ -0,0 +1,410 @@ | |||
<?xml version="1.0"?> | |||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make more sense to put this documentation in a README file in the directory? I wouldn't normally think to look inside a .world file for instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Carl, can you add a short README instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, the README file is still work in progress.
@@ -0,0 +1,410 @@ | |||
<?xml version="1.0"?> | |||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Carl, can you add a short README instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the what this is and why to the README too?
Yes, the |
|
||
$ ros2 run tf2_ros static_transform_publisher 0.75 0 0.484 0 0 0 base_link ray_link | ||
|
||
On RViz, change the Fixed Frame" to ```ray_link``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray quote (") after Fixed Frame?
# Bringup | ||
|
||
## Before starting: | ||
- Build ROS2 from master branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"from the master branch"
## Before starting: | ||
- Build ROS2 from master branch | ||
- If working with Ubuntu 16, install [Gazebo 9](http://gazebosim.org/tutorials?tut=install_ubuntu&cat=install) | ||
- In step #3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was immediately obvious that the text was referring to step 3 n the gazebo install tutorial. Could make this explicit: "In step #3 in the gazebo installation instructions" or something like that.
@@ -0,0 +1,65 @@ | |||
# Bringup | |||
|
|||
## Before starting: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear if this is a README for the bring-up of the Navigation 2 system or just describing how to bring up gazebo. The location in nav2_bringup would indicate that it should describe how to bring up the whole system. We should also include instructions for starting the nav2 system.
Closing this one at least until Carlos is back, at which time we can revisit if needed. |
Co-authored-by: andriimaistruk <andriimaistruk@logivations.com>
... for testing the nav stack. We can use this one while we wait for Turtlebot to be fully supported in ROS2.
This robot has a differential drive, laser, and imu sensors. Uses the corresponding ros_gazebo_plugins to interface with Gazebo.