Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a demo robot #241

Closed
wants to merge 4 commits into from
Closed

Adding a demo robot #241

wants to merge 4 commits into from

Conversation

orduno
Copy link
Contributor

@orduno orduno commented Oct 25, 2018

... for testing the nav stack. We can use this one while we wait for Turtlebot to be fully supported in ROS2.

This robot has a differential drive, laser, and imu sensors. Uses the corresponding ros_gazebo_plugins to interface with Gazebo.

@SteveMacenski
Copy link
Member

Is this here because the spawn_model hasnt been ported to ros2 yet (unsure)? If it has, there are world files turtlebot simulation (that's already a ros1 kinetic/melodic dependency nav2 pulls in). I'd just grab one of those and a model spawner in a (py) launch file

https://github.com/ROBOTIS-GIT/turtlebot3_simulations/tree/master/turtlebot3_gazebo/worlds

@@ -0,0 +1,410 @@
<?xml version="1.0"?>
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make more sense to put this documentation in a README file in the directory? I wouldn't normally think to look inside a .world file for instructions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Carl, can you add a short README instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, the README file is still work in progress.

@@ -0,0 +1,410 @@
<?xml version="1.0"?>
<!--
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Carl, can you add a short README instead?

Copy link
Collaborator

@mkhansenbot mkhansenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the what this is and why to the README too?

@orduno
Copy link
Contributor Author

orduno commented Oct 26, 2018

Is this here because the spawn_model hasnt been ported to ros2 yet (unsure)? If it has, there are world files turtlebot simulation (that's already a ros1 kinetic/melodic dependency nav2 pulls in). I'd just grab one of those and a model spawner in a (py) launch file

https://github.com/ROBOTIS-GIT/turtlebot3_simulations/tree/master/turtlebot3_gazebo/worlds

Yes, the spawn_model hasn't been ported to ROS2.


$ ros2 run tf2_ros static_transform_publisher 0.75 0 0.484 0 0 0 base_link ray_link

On RViz, change the Fixed Frame" to ```ray_link```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray quote (") after Fixed Frame?

# Bringup

## Before starting:
- Build ROS2 from master branch

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"from the master branch"

## Before starting:
- Build ROS2 from master branch
- If working with Ubuntu 16, install [Gazebo 9](http://gazebosim.org/tutorials?tut=install_ubuntu&cat=install)
- In step #3:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was immediately obvious that the text was referring to step 3 n the gazebo install tutorial. Could make this explicit: "In step #3 in the gazebo installation instructions" or something like that.

@@ -0,0 +1,65 @@
# Bringup

## Before starting:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear if this is a README for the bring-up of the Navigation 2 system or just describing how to bring up gazebo. The location in nav2_bringup would indicate that it should describe how to bring up the whole system. We should also include instructions for starting the nav2 system.

@mkhansenbot
Copy link
Collaborator

Closing this one at least until Carlos is back, at which time we can revisit if needed.

@orduno orduno deleted the simplebot branch October 1, 2019 17:55
ghost pushed a commit to logivations/navigation2 that referenced this pull request Mar 7, 2022
Co-authored-by: andriimaistruk <andriimaistruk@logivations.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants