Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount overlay workspace into Dev Container via volume #3524

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Mount overlay workspace into Dev Container via volume #3524

merged 5 commits into from
Apr 3, 2023

Commits on Apr 3, 2023

  1. Add volume for overlay 

    to avoid rebuilding it from scratch
whenever the dev container is rebuilt
this saves startup time locally when fiddling with the configs
    @ruffsl
    ruffsl committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    7d20516 View commit details
    Browse the repository at this point in the history

  2. Append devcontainerId to volume name 

    to avoid conflicts with other devcontainers
note that devcontainerId is stable across rebuilds
- https://containers.dev/implementors/json_reference/#variables-in-devcontainerjson
    @ruffsl
    ruffsl committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9356776 View commit details
    Browse the repository at this point in the history

  3. Call updateContentCommand from onCreateCommand 

    to deduplicate scripts and keep setup DRY
given the addition of a mounted overlay volume
which could include a prebuilt colcon workspace
well before the dev container is created/rebuilt
    @ruffsl
    ruffsl committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    ab508f8 View commit details
    Browse the repository at this point in the history

  4. Comment out colcon clean from setup 

    to avoid unintentional removal of built packages
from the persistent overlay workspace volume.
Users can uncomment the line locally
or simply remove the overlay workspace volume
if they want to rebuild packages from scratch.
    @ruffsl
    ruffsl committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    3ea09f9 View commit details
    Browse the repository at this point in the history

  5. Format json

    @ruffsl
    ruffsl committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    cc6b86d View commit details
    Browse the repository at this point in the history