Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing destructor to MPPI critic manager #3812

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Added missing destructor to MPPI critic manager #3812

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c5062d
Added missing virtual destructor
VineetTambe Sep 12, 2023
3ab157a
Updated CriticManger Destructor to be same as other branches
VineetTambe Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nav2_mppi_controller/include/nav2_mppi_controller/critic_manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class CriticManager
* @brief Constructor for mppi::CriticManager
*/
CriticManager() = default;
~CriticManager() = default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the compiler not simply do this for us? But no matter, we can accept this, no problem

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did not in my case.
I am running a pretty standard setup and just have done a fresh install of Ubuntu 22.04 and ROS2 humble.
So that made me think that this might be a pretty common problem.


/**
* @brief Configure critic manager on bringup and load plugins
Expand Down