Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NaNs in AMCL beam sensor model (backport #3929) #3937

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 3, 2023

This is an automatic backport of pull request #3929 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Handle NaNs in AMCL beam sensor model

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Use proper isnan check

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

---------

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
(cherry picked from commit 06c3550)
Copy link
Contributor Author

mergify bot commented Nov 3, 2023

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @humble, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski merged commit 3680acb into humble Nov 3, 2023
@SteveMacenski SteveMacenski deleted the mergify/bp/humble/pr-3929 branch November 3, 2023 18:19
RBT22 pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Nov 16, 2023
…gation#3937)

* Handle NaNs in AMCL beam sensor model

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Use proper isnan check

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

---------

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
(cherry picked from commit 06c3550)

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
RBT22 pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Nov 16, 2023
…gation#3937)

* Handle NaNs in AMCL beam sensor model

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Use proper isnan check

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

---------

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
(cherry picked from commit 06c3550)

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Nov 20, 2023
…gation#3937)

* Handle NaNs in AMCL beam sensor model

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Use proper isnan check

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

---------

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
(cherry picked from commit 06c3550)

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants