Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humble release 11: May 23, 2024 #4365

Merged
merged 19 commits into from
May 23, 2024

Revert "[LifecycleNode] add bond_heartbeat_period (#4342)"

0ec456e
Select commit
Loading
Failed to load commit list.
Merged

Humble release 11: May 23, 2024 #4365

Revert "[LifecycleNode] add bond_heartbeat_period (#4342)"
0ec456e
Select commit
Loading
Failed to load commit list.
DCO / DCO required action May 23, 2024 in 0s

DCO

There are 14 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~19 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin humble_syncN

Summary

Commit sha: deff075, Author: AzaelCicero, Committer: Steve Macenski; Expected "AzaelCicero k.t.pawelczyk@gmail.com", but got "Krzysztof Pawełczyk k.t.pawelczyk@gmail.com".
Commit sha: cf6a8f8, Author: BriceRenaudeau, Committer: Steve Macenski; Can not find "BriceRenaudeau 48433002+BriceRenaudeau@users.noreply.github.com", in ["Brice brice.renaudeau@gmail.com", "Brice brice.renaudeau@gmail.com", "Brice brice.renaudeau@gmail.com"].
Commit sha: 3589307, Author: GoesM, Committer: Steve Macenski; Can not find "GoesM 130988564+GoesM@users.noreply.github.com", in ["goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn"].
Commit sha: 0f7d120, Author: GoesM, Committer: Steve Macenski; Can not find "GoesM 130988564+GoesM@users.noreply.github.com", in ["goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn", "goes GoesM@buaa.edu.cn"].
Commit sha: 6e44178, Author: Guillaume Doisy, Committer: Steve Macenski; Can not find "Guillaume Doisy doisyg@users.noreply.github.com", in ["Guillaume Doisy guillaume@dexory.com", "Guillaume Doisy guillaume@dexory.com", "Guillaume Doisy guillaume@dexory.com"].
Commit sha: a4daa54, Author: Guillaume Doisy, Committer: Steve Macenski; Expected "Guillaume Doisy doisyg@users.noreply.github.com", but got "Guillaume Doisy guillaume@dexory.com".
Commit sha: 5cbde5c, Author: Pedro Alejandro González, Committer: Steve Macenski; Can not find "Pedro Alejandro González 71234974+pepisg@users.noreply.github.com", in ["pepisg pedro.gonzalez@eia.edu.co", "pepisg pedro.gonzalez@eia.edu.co", "pepisg pedro.gonzalez@eia.edu.co"].
Commit sha: e5d5927, Author: Sokolov Denis, Committer: Steve Macenski; Can not find "Sokolov Denis 52282102+perchess@users.noreply.github.com", in ["Denis Sokolov denis.sokolov48@gmail.com", "Denis Sokolov denis.sokolov48@gmail.com", "Denis Sokolov denis.sokolov48@gmail.com", "Denis Sokolov denis.sokolov48@gmail.com", "Denis Sokolov denis.sokolov48@gmail.com"].
Commit sha: 8e59fb2, Author: Steve Macenski, Committer: Steve Macenski; The sign-off is missing.
Commit sha: 4ca5a25, Author: Steve Macenski, Committer: Steve Macenski; The sign-off is missing.
Commit sha: 33a05c9, Author: Steve Macenski, Committer: Steve Macenski; The sign-off is missing.
Commit sha: 1e08115, Author: Steve Macenski, Committer: Steve Macenski; The sign-off is missing.
Commit sha: 0ec456e, Author: Steve Macenski, Committer: Steve Macenski; The sign-off is missing.
Commit sha: 3586afa, Author: Wiktor Bajor, Committer: Steve Macenski; Can not find "Wiktor Bajor 69388767+Wiktor-99@users.noreply.github.com", in ["Wiktor Bajor wiktorbajor1@gmail.com", "Wiktor Bajor wiktorbajor1@gmail.com", "Wiktor Bajor wiktorbajor1@gmail.com", "Wiktor Bajor wiktorbajor1@gmail.com", "Wiktor Bajor wiktorbajor1@gmail.com", "Wiktor Bajor wiktorbajor1@gmail.com", "Wiktor Bajor wiktorbajor1@gmail.com", "Wiktor Bajor wiktorbajor1@gmail.com", "Wiktor Bajor wiktorbajor1@gmail.com"].