Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/port systems tests failure to new gazebo #4453

Conversation

stevedanomodolor
Copy link
Contributor

@stevedanomodolor stevedanomodolor commented Jun 20, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
@stevedanomodolor stevedanomodolor marked this pull request as ready for review June 20, 2024 21:10
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 5 files with indirect coverage changes

@SteveMacenski SteveMacenski merged commit a82090f into ros-navigation:main Jun 20, 2024
11 checks passed
ajtudela pushed a commit to ajtudela/navigation2 that referenced this pull request Jun 21, 2024
* migrate system failures test to new gazebo

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

* cleanly kill gz sim in gazebo

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

* use robot publisher and kill gz sim

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

---------

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
* migrate system failures test to new gazebo

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

* cleanly kill gz sim in gazebo

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

* use robot publisher and kill gz sim

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

---------

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
* migrate system failures test to new gazebo

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

* cleanly kill gz sim in gazebo

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

* use robot publisher and kill gz sim

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

---------

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
@stevedanomodolor stevedanomodolor deleted the feat/port_systems_tests_failure_to_new_gazebo branch July 9, 2024 18:30
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
* migrate system failures test to new gazebo

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

* cleanly kill gz sim in gazebo

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

* use robot publisher and kill gz sim

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>

---------

Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants