Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string error_msg to all action result messages (#4341) #4459

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

aosmw
Copy link
Contributor

@aosmw aosmw commented Jun 22, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses 4341
Primary OS tested on Ubuntu
Robotic platform tested on none
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Added string error_msg to all action result messages and uint16 error_code where it was missing.

Description of documentation updates required from your changes

Notify interface change.

Future work that may be required in bullet points

Future work is to make the changes to the action implementations to populate the error_msg / error_code fields where appropriate.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

@SteveMacenski SteveMacenski merged commit acea1ef into ros-navigation:main Jun 24, 2024
11 checks passed
ajtudela pushed a commit to ajtudela/navigation2 that referenced this pull request Jun 26, 2024
ajtudela pushed a commit to ajtudela/navigation2 that referenced this pull request Jun 26, 2024
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants