Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Docking panel (backport #4717) #4725

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Improve Docking panel (backport #4717) #4725

merged 1 commit into from
Oct 17, 2024

Conversation

ajtudela
Copy link
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses #4689
Primary OS tested on Ubuntu 24.04
Robotic platform tested on Morphia robot
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Improved internal state machine to fix randomly RVIZ crashes.
  • Improved the UI.
Captura desde 2024-10-07 12-43-26 Captura desde 2024-10-08 11-06-38
Before After

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@ajtudela
Improve Docking panel (ros-navigation#4717)
b49458e 
* Added load and save panel

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Improved dock_panel state machine

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Added loading dock plugins log

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Redo UI

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Update tooltips

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Fix null-dereference

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

---------

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 17, 2024

@ajtudela, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@ajtudela ajtudela mentioned this pull request Oct 17, 2024
Merged
7 tasks
@ajtudela
Copy link
Contributor Author

It seems that CI failed due to amcl :S

@evshary evshary mentioned this pull request Oct 17, 2024
Closed
@SteveMacenski SteveMacenski merged commit ea89360 into ros-navigation:jazzy Oct 17, 2024
7 of 8 checks passed
@ajtudela ajtudela deleted the backport_dock_panel branch October 17, 2024 16:31
@evshary evshary mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajtudela @SteveMacenski