Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky mppi test #4933

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mini-1235
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4932
Primary OS tested on Ubuntu
Robotic platform tested on gazebo sim
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Fixed the flaky test as mentioned in the issue, added a new one for non-regenerate noise

Description of documentation updates required from your changes

Description of how this change was tested

Unit test, run around 10000 rounds


Future work that may be required in bullet points

Currently in noise generator we have 3 tests, the first test NoiseGeneratorLifecycle is actually covered by my new one, should we delete this test or keep it?

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant