-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[RPP] Prevent collision check premature termination with scaled_lookahead #5677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[RPP] Prevent collision check premature termination with scaled_lookahead #5677
Conversation
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Érico Meger <86668447+EricoMeger@users.noreply.github.com> Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
|
This PR should address the cases we discussed. |
Codecov Report❌ Patch coverage is
... and 24 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Sorry for the delay - ROSCon + vacation delayed me and getting back up to everything :-) Looking now. Can you handle the merge conflict GitHub is reporting? |
|
@doisyg and @mini-1235 were involved in the discussions leading to this PR. Can you guys review / give you opinion on this vs the other PRs that were reverted to make sure it fixes the need? |
| // prevents the checker from looking "through" the goal | ||
| // considering the safe distance until the path end | ||
| const double effective_min_dist = std::min(params_->min_distance_to_obstacle, | ||
| dist_to_path_end); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| dist_to_path_end); | |
| dist_to_path_end); |
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Added new parameter, so need to add that to default configs and documentation page
Description of how this change was tested
Ran multiple tests on both a physical platform and simulation. Tests included different maps, routes, and parameter configurations (e.g., varying footprint sizes, velocities, and safety distances)
Future work that may be required in bullet points
For Maintainers:
backport-*.