Ellon feature/covariances kinetic devel #1096
Conversation
The visual of the covariance is defined by CovarianceVisual class. The angular part should be improved.
- Use more Ogre Scene Nodes to position/rotate/scale shapes - Use an 4 shapes for orientation: 3 ellipses for 3D posed and one cone for 2D poses - Display flat objects when dealing with 2D poses (cov of z, roll, pitch <= 0.0) - Make this visual constructble only from CovarianceProperty
- The property holds all the CovarianceVisual instances, and updates them then covariance properties change, without passing by the parent display. - Moved it from properties to to default_plugin
…y display Let CovarianceProperty handle how to exhibit a CovarianceVisual
Also let CovarianceProperty handle the exhibition of CovarianceVisuals
|
@Ellon I need you to copyright and license your newly added files for this pr. The easiest thing to do is put it under the same license. If you're fine with that, please make a pr against this branch which copies the copyright/license stanza from one of the other files and replace the copyright (probably for Willow Garage) with your own copyright. Thanks! |
|
For a few files you copied the stanza, but left Willow Garage as the copyright holder, please replace that with yourself or your company/school if that's appropriate. |
|
Hey @wjwwood, I updated the licenses in #1097 . Is that OK for you? I also think we should wait for a feedback from @thomas-moulard, since he was the original author of the plugin, and his files didn't contained copyright/license. Btw, I developed a little bit more the plugin. I have the commits in my personal repo. Should I take the opportunity and add these modifications here? |
|
@Ellon Adding those copyright header is OK, thanks! |
|
Thanks guys, I need to release rviz again since there is a regression for some systems, so I'll get this in too. |
|
By "this" you mean this merge here, or the other stuff I mentioned? |
|
I didn't see the this, edits don't send notifications. Yes. If you've updated the plugin it would be good to get those changes into rviz. |
|
Done in #1099 |
Replacement for #974