-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable dock widget text eliding #1168
Disable dock widget text eliding #1168
Conversation
Rebased against current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good thank you @VictorLamoine !
for future reference I tested with this config: |
I think this PR introduces a Qt5 dependency, but branch kinetic-devel is
QList<QTabBar *> tab_bars = findChildren<QTabBar *>(QString(), Qt::FindDirectChildrenOnly); The Everything seems to build fine with Qt4 and without the commits. |
@theobslhc, thanks for reporting this issue. Please file a new issue for this, referring to this PR. |
See issue #1369. |
Replace Qt5-only Qt::FindDirectChildrenOnly (introduced in #1168) with Qt4-friendly solution.
Fixes #1148
Diff without trailing whitespace changes:
https://github.com/ros-visualization/rviz/compare/kinetic-devel...VictorLamoine:QTabWidget_elide?w=1
The new slot
onDockPanelChange
checks for every QTabBar there is in the main window and makes sure text is not elided inside it.This slot is triggered
Before
After