Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dock widget text eliding #1168

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Disable dock widget text eliding #1168

merged 2 commits into from
Apr 26, 2018

Conversation

VictorLamoine
Copy link
Contributor

@VictorLamoine VictorLamoine commented Nov 2, 2017

Fixes #1148

Diff without trailing whitespace changes:
https://github.com/ros-visualization/rviz/compare/kinetic-devel...VictorLamoine:QTabWidget_elide?w=1

The new slot onDockPanelChange checks for every QTabBar there is in the main window and makes sure text is not elided inside it.

This slot is triggered

  • When a config file is loaded
  • When a panel is created
  • When a panel is moved

Before

default_behaviour

After

no_elide

@VictorLamoine VictorLamoine changed the title Q tab widget elide Disable dock widget text eliding Nov 2, 2017
@VictorLamoine
Copy link
Contributor Author

Rebased against current kinetic-devel.

@dhood dhood self-assigned this Apr 7, 2018
Copy link
Contributor

@dhood dhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thank you @VictorLamoine !

@dhood
Copy link
Contributor

dhood commented Apr 7, 2018

for future reference I tested with this config:
test_tab_eliding.rviz.txt

@dhood dhood merged commit 921767b into ros-visualization:kinetic-devel Apr 26, 2018
@VictorLamoine VictorLamoine deleted the QTabWidget_elide branch August 8, 2018 10:04
@theobslhc
Copy link

theobslhc commented Apr 23, 2019

I think this PR introduces a Qt5 dependency, but branch kinetic-devel is supposed to be Qt4-compatible. (Edit: it's not)

src/rviz/visualization_frame.cpp, line 1208

QList<QTabBar *> tab_bars = findChildren<QTabBar *>(QString(), Qt::FindDirectChildrenOnly);

The Qt::FindDirectChildrenOnly flag was introduced in Qt5.

Everything seems to build fine with Qt4 and without the commits.
Is there any solution that would not rely on Qt:FindDirectChildrenOnly flag? (I might try to look into that myself soon - will update)

@rhaschke
Copy link
Contributor

@theobslhc, thanks for reporting this issue. Please file a new issue for this, referring to this PR.
@VictorLamoine Do you have an idea to handle this issue?

@theobslhc
Copy link

See issue #1369.

rhaschke pushed a commit that referenced this pull request Apr 25, 2019
Replace Qt5-only Qt::FindDirectChildrenOnly (introduced in #1168) with Qt4-friendly solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants