Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate nav_view into an ogre_visualizer panel (ros-pkg ticket #383) #17

Closed
hershwg opened this issue Sep 19, 2012 · 1 comment
Closed

Comments

@hershwg
Copy link
Member

hershwg commented Sep 19, 2012

nav_view is really just an orthographic version of what's now called ogre_visualizer, with some specialized input tools. There are two options here:

  1. Provide orthographic camera functionality in the existing ogre_visualizer, along with the ability to add custom tool support, and figure out some way of dealing with the fact that the map is such an integral part of nav_view

  2. Break out the common functionality into visualizer_framework. Implement what is now the 3d visualizer in another package (vis3d?) using the framework. Implement nav_view using the framework as well.

I'm leaning towards option 2.

trac data:

@hershwg
Copy link
Member Author

hershwg commented Sep 19, 2012

[jfaust] nav_view functionality has been integrated into ogre_visualizer

@hershwg hershwg closed this as completed Sep 19, 2012
emersonknapp pushed a commit to emersonknapp/rviz that referenced this issue Mar 1, 2019
* Introduce linters in rviz_rendering

- we don't use ament_lint_common because copyright checks fail
- we want to wait for changes in ament_copyright before fixing

* Fix cppcheck errors

- only one error: memory leak of log_manager

* Extract SdkQtCameraMan from OgreBites to fix linters

- SdkQtCameraMan is from OgreBites and not from rviz
- No change in functionality

* adding a todo about the copyright linter

* add a comment about delete-less new call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant